[18.0][MIG] web_widget_bokeh_chart #3076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid "Duplicate explicit target name" error using anonymous hyperlink references Ref.: https://stackoverflow.com/questions/5464627/how-to-have-same-text-in-two-links-with-restructured-text/14067756#14067756
…ontainer element.
…mit dynamic updates
Includes some manual fixes to silent ESLint warnings.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_widget_bokeh_chart Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_bokeh_chart/
Co-authored-by: Enric Tobella [email protected] Co-authored-by: David Jimenez [email protected]
Update bokeh from 3.1.1 to 3.4.1
|
When debug mode is enabled, the console shows this error: |
| @@ -0,0 +1,52 @@ | |||
| /* global document */ | |||
| import {markup, onMounted, onPatched, onWillStart, useRef} from "@odoo/owl"; | |||
| import {CharField} from "@web/views/fields/char/char_field"; | |||
There was a problem hiding this comment.
Add charField import and change export to:
export const bokehChartWidget = {
...charField,
component: BokehChartWidget,
};
To fix the console error when debug mode is enabled
There was a problem hiding this comment.
Updated, Thanks
| }); | ||
| super.setup(); | ||
| onWillStart(() => | ||
| loadBundle({ |
There was a problem hiding this comment.
since 18.0 loadBundle function only permit string arguments. Try to call loadJS function for every path inside a function.
export async function loadBokehLibraries() {
const scripts = [
"/web_widget_bokeh_chart/static/src/lib/bokeh/bokeh-3.4.1.min.js",
"/web_widget_bokeh_chart/static/src/lib/bokeh/bokeh-api-3.4.1.min.js",
"/web_widget_bokeh_chart/static/src/lib/bokeh/bokeh-widgets-3.4.1.min.js",
"/web_widget_bokeh_chart/static/src/lib/bokeh/bokeh-tables-3.4.1.min.js",
"/web_widget_bokeh_chart/static/src/lib/bokeh/bokeh-mathjax-3.4.1.min.js",
"/web_widget_bokeh_chart/static/src/lib/bokeh/bokeh-gl-3.4.1.min.js",
];
for (const script of scripts) {
await loadJS(script);
}
}
And then call it inside onWillStart:
onWillStart(() => loadBokehLibraries());
By this way, the function could be called from other modules.
There was a problem hiding this comment.
Updated, Thanks
There was a problem hiding this comment.
Please apply the same logic to web_widget_bokeh_json_chart.esm.js file
JasminSForgeFlow
force-pushed
the
18.0-mig-web_widget_bokeh_chart
branch
3 times, most recently
from
7720806 to
94be57c
Compare
JasminSForgeFlow
force-pushed
the
18.0-mig-web_widget_bokeh_chart
branch
from
94be57c to
1b75d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard Migration
@ForgeFlow